do not delete local ls config on upgrade #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the upgrade script to avoid deleting local configuration files during cleanup by broadening the hidden pattern.
- Changed
ls --hidepattern to exclude all*.config.jsonfiles. - Maintained removal of other artifacts via
rm -rf.
Comments suppressed due to low confidence (1)
mytonctrl/scripts/upgrade.sh:86
- The
--hideoption is a GNUlsextension and may not be available on all platforms (e.g., BSD/macOS). For portability, prefer afind-based approach to filter out*.config.jsonacross environments.
ls --hide="*.config.json" | xargs -d '\n' rm -rf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.