feat: add tonkeeper wallet docs #1274
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aigerimu Is there? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - 🟡 **Account balance** displays the total amount of Toncoin and other tokens held on account. | ||
| - 🔴 **Account address** is shown as a base64-encoded string. It can be shared to receive TON, jettons, or NFTs. | ||
| - 🟢 **Send/Receive/Scan buttons** are used to transfer TON or jettons to another account, receive TON or jettons to the wallet, and scan QR codes to confirm transactions, respectively. |
There was a problem hiding this comment.
[HIGH] Emojis used in prose bullets
These bullets in running prose use emojis, which are prohibited in prose and headings. Emojis reduce clarity and translate poorly. See https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L101-L103 for the rule forbidding emojis in prose. Replace them with plain text to keep labels concise and localizable.
| - 🟡 **Account balance** displays the total amount of Toncoin and other tokens held on account. | |
| - 🔴 **Account address** is shown as a base64-encoded string. It can be shared to receive TON, jettons, or NFTs. | |
| - 🟢 **Send/Receive/Scan buttons** are used to transfer TON or jettons to another account, receive TON or jettons to the wallet, and scan QR codes to confirm transactions, respectively. |
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
| <Aside | ||
| type="caution" | ||
| title="Funds at risk" | ||
| > | ||
| Addresses of both mainnet and testnet accounts can be derived from the same mnemonic, i.e. the same key might be used for both wallets. Beware these accounts exist only in their corresponding networks. | ||
|
|
||
| It's possible to forget switching to testnet, and accidentally spend real funds on mainnet. | ||
|
|
||
| It's possible to accidentally transfer funds to a testnet wallet address on mainnet. These funds will be impossible to recover. | ||
|
|
||
| Verify which network is used before any funds are sent. | ||
| </Aside> |
There was a problem hiding this comment.
[HIGH] Funds‑risk callout uses wrong type and misses required elements (Create a wallet)
This callout warns about risks that can cause loss of funds across networks, but uses type="caution" instead of a Warning (type="danger"). It also lacks required elements: explicit scope, rollback/mitigation, and environment labeling. The safety callout rules require risk, scope, rollback, and environment, and mandate correct mapping and use of <Aside>; see https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L556-L567.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
| <Aside | ||
| type="caution" | ||
| title="Funds at risk" | ||
| > | ||
| On-chain transfers are irreversible — verify the recipient and amount before confirming. Use testnet for practice; use mainnet only for real transfers. | ||
| </Aside> |
There was a problem hiding this comment.
[HIGH] Funds‑risk callout uses wrong type and misses required elements (Deploy the code)
This step involves sending funds and presents a funds/keys risk, but uses type="caution" where a Warning (type="danger") is required. The callout also omits the mandatory scope and rollback statements. Safety callout content and mapping rules are defined in https://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L556-L567.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Closes #137
There is a missing link to the how to get testnet section. It might be added now or once the #599 is merged.
Redo of a #598 that somehow broke CI