-
Notifications
You must be signed in to change notification settings - Fork 1
feat(guidebook): more tutorials #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the docs updates around the guidebook pages. One blocking fix is needed before merge. Findings (1)High (1)[HIGH] Broken internal link to missing pageDescription: Suggestion: <Columns cols={2}>
- <Card
- title="See examples"
- icon="code-simple"
- href="/techniques/examples"
- />
<Card
title="Tolk gas benchmark contracts"
icon="code" |
Yes, and I've added it in another PR, which precedes this one — #552. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this article could use more simple formatting.
It's just a list of different resources. The extra space could have been used to describe why that particular class/course is different from the others.
Thanks for the PR and the clear changes. Based on the diff between |
Thanks for the updates. I reviewed the changes between main and pr_head; I found no issues, and no fixes are needed. |
Thanks for pushing this PR. I reviewed the changes between main and pr_head across the updated files, and I found no issues—no fixes needed from my side. |
Thanks for the PR. I reviewed the diff from I found no issues in this review; no fixes needed. |
Closes #94. I've applied AI review suggestions here already.
The change in
package.json
is from #552 — I've decided to split those PRs into two to simplify review processes, but in order for the linter to pass some settings from that one had to come over to this one.