-
Notifications
You must be signed in to change notification settings - Fork 1
wallet.ton.org #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wallet.ton.org #583
Conversation
To fix the formatting issues:
npx remark -o --quiet --silently-ignore ecosystem/wallet-apps/web.mdx |
Thanks for the updates to the wallet docs. A few blocking issues remain in the web wallet page that need fixes before we can merge. Findings (3)High (3)[HIGH] Misleading link target for “wallet.ton.org”Description: Suggestion: - [wallet.ton.org](https://github.com/ton-blockchain/ton-wallet) is the self-custodial wallet developed by TON Core.
+ [wallet.ton.org](https://wallet.ton.org/) is the self-custodial wallet developed by TON Core. [HIGH] Incomplete sections and placeholder steps block useDescription: Suggestion: -## Wallet setup
-
-We demonstrate wallet setup using the **web version** of [wallet.ton.org](https://wallet.ton.org/).
-This allows developers to complete all steps on a single device without switching platforms.
-
-1. Open
-
-
-### Testnet
-
-
-## First transactions
-
-
-## See also [HIGH] Incomplete procedure step blocks task executionDescription: Suggestion: -1. Open
+1. Open https://wallet.ton.org/. |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
Thanks for the update to the wallet docs. I found a few blocking issues in ecosystem/wallet-apps/web.mdx that need fixes before merge. Findings (4)High (4)[HIGH] Missing security warning for recovery wordsDescription: Suggestion: -<Aside type="caution">
- The following recovery words are shown only for demonstration purposes.
-</Aside>
+<Aside type="warning">
+ Warning — funds and keys at risk
+ Exposing or storing recovery words can compromise your wallet.
+ Scope: anyone with these words can take your funds.
+ Rollback: none. If leaked, move funds to a new wallet.
+ Environment: applies to TON Mainnet and TON Testnet.
+ The words below are for demonstration only.
+</Aside> [HIGH] Step numbering skips 4–5 and continues at 6–10Description: Suggestion: -6. Read the **Use Responsibly** notice and check the box to _confirm that you have read and accepted this information_.
+4. Read the **Use Responsibly** notice and check the box to _confirm that you have read and accepted this information_.
-7. After confirming, you’ll be prompted to manually back up your secret key.
+5. After confirming, you’ll be prompted to manually back up your secret key.
-8. Read the **Safety Rules** carefully, check all the boxes to confirm that you understand them. Then click **Understood** to continue.
+6. Read the **Safety Rules** carefully, check all the boxes to confirm that you understand them. Then click **Understood** to continue.
-9. Write down your 24 recovery words and store them in **a safe place**.
+7. Write down your 24 recovery words and store them in **a safe place**.
-10. In the **Let’s Check** step, enter the requested words to make sure your recovery phrase was saved correctly.
+8. In the **Let’s Check** step, enter the requested words to make sure your recovery phrase was saved correctly. [HIGH] Placeholder faucet link is brokenDescription: Suggestion: -- On Testnet, request free Testnet Toncoins from the [TON Testnet Faucet](link).
+- On Testnet, request free Testnet Toncoins from the [TON Testnet Faucet](https://t.me/testgiver_ton_bot). [HIGH] Incorrect account status term (“nonexistent” vs canonical “nonexist”)Description: Suggestion: -Newly created wallets have the default state **nonexistent**, meaning the account has _no code, data, or balance_.
+Newly created wallets have the default state **nonexist**, meaning the account has _no code, data, or balance_. |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
![]() it suggests:
So, could we ignore it? |
Thanks for the focused docs update in the ecosystem wallet guide. I found several style‑guide blockers that need fixes before merge. Findings (3)High (3)[HIGH] UI/log messages are styled in bold instead of quotedDescription: Suggestion: --- a/ecosystem/wallet-apps/web.mdx
+++ b/ecosystem/wallet-apps/web.mdx
@@ -31 +31 @@
-2. Click **Create Wallet** to create a new wallet.
+2. Click "Create Wallet" to create a new wallet.
@@ -39 +39 @@
-3. Next, choose **Use Password** to protect your wallet:
+3. Next, choose "Use Password" to protect your wallet:
@@ -259 +259 @@
-1. Click **Send**, enter your wallet address in **Recipient Address**, and the **Amount** of TON. Optionally, add a comment. Click **Send TON**.
+1. Click "Send", enter your wallet address in "Recipient Address", and the "Amount" of TON. Optionally, add a comment. Click "Send TON".
@@ -267 +267 @@
-2. In the confirmation popup, verify the transaction details and click **Confirm** if correct; otherwise, **Edit**.
+2. In the confirmation popup, verify the transaction details and click "Confirm" if correct; otherwise, "Edit".
@@ -275 +275 @@
-3. After confirmation, the wallet will display a notification: **Coins have been sent!**
+3. After confirmation, the wallet displays the notification "Coins have been sent!" [HIGH] Safety callout for mnemonic handling is incomplete (missing risk, scope, rollback, environment)Description: Suggestion: -<Aside
- type="caution"
->
- The following recovery words are shown only for demonstration purposes.
-</Aside>
+<Aside type="danger" title="Secrets at risk">
+ Risk: Exposing recovery words lets others take your wallet and funds.
+ Scope: Affects this wallet and any accounts derived from its mnemonic.
+ Rollback: If exposure is suspected, move funds to a new wallet and stop using the old mnemonic.
+ Environment: Handle mnemonics offline and in private; do not enter them on untrusted sites. Prefer Testnet for demos.
+</Aside> [HIGH] Missing required safety callout before moving fundsDescription: Suggestion: ### Send the first transaction
With TON in the account, the wallet can be deployed. Deployment occurs when _the wallet processes its first transaction_.
In this example, we send TON to the account itself on Testnet to observe the transaction and wallet deployment on-chain.
+<Aside type="danger" title="Funds at risk">
+ Risk: The next steps transfer funds. Mainnet transfers are irreversible.
+ Scope: Your wallet balance and the specified recipient address.
+ Mitigation/Rollback: Use TON Testnet for this example. On mainnet, double‑check the recipient and amount before confirming; there is no rollback after submission.
+ Environment: Prefer TON Testnet for testing; switch to mainnet only when ready.
+</Aside>
To send TON to your own account: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aigerimu merge conflicts + failing CI
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/web.mdx |
done |
ecosystem/wallet-apps/web.mdx
Outdated
## Key features | ||
|
||
- **Testnet support:** accepts the `testnet` parameter in the browser. | ||
- **Security-focused development:** covered by [TON security bug bounty](https://github.com/ton-blockchain/bug-bounty). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section says it is not covered by ton-blockchain/bug-bounty:
https://github.com/ton-blockchain/bug-bounty?tab=readme-ov-file#frontend
Thanks for the focused work on the wallet-apps guide. There are a few high‑severity style and safety items that need addressing before this can merge. Findings (4)High (4)[HIGH] UI strings not quoted per house rule; tokens need code fontLocation: docs/ecosystem/wallet-apps/web.mdx Lines 22 to 30 in 3c04b3b
Description: Suggestion: --- a/ecosystem/wallet-apps/web.mdx
+++ b/ecosystem/wallet-apps/web.mdx
@@
-1. Click **Create Wallet** to create a new wallet.
+1. Click “Create Wallet” to create a new wallet.
@@
-2. Next, choose **Use Password** to protect your wallet:
+2. Next, choose “Use Password” to protect your wallet:
@@
-Once you’re ready, click **Let’s Check** to verify your recovery phrase.
+Once you’re ready, click “Let’s Check” to verify your recovery phrase. -1. Click **Create Wallet** to create a new wallet.
+1. Click "Create Wallet" to create a new wallet.
-2. Next, choose **Use Password** to protect your wallet:
+2. Next, choose "Use Password" to protect your wallet:
-3. After confirmation, the wallet will display a notification: **Coins have been sent!**
+3. After confirmation, the wallet will display a notification: "Coins have been sent!" -1. Click **Create Wallet** to create a new wallet.
+1. Click “Create Wallet” to create a new wallet. -2. In the **Wallet Versions**, you can see which contract your wallet uses.
+2. In “Wallet Versions”, you can see which contract your wallet uses. -3. After confirmation, the wallet will display a notification: **Coins have been sent!**
+3. After confirmation, the wallet displays the notification: “Coins have been sent!” -You will also see a **Contract Type** field indicating **v5**.
+You will also see a “Contract Type” field indicating `v5`. [HIGH] Mnemonic safety callout is incomplete (missing required elements)Location: docs/ecosystem/wallet-apps/web.mdx Lines 76 to 80 in 3c04b3b
Description: Suggestion: -<Aside
- type="caution"
->
- The following recovery words are shown only for demonstration purposes.
-</Aside>
+<Aside type="danger" title="Secrets at risk">
+ Risk: Anyone who sees or records these 24 words can take control of your wallet and funds.
+ Scope: This affects your wallet on both mainnet and testnet.
+ Rollback: If exposed, create a new wallet and transfer all funds immediately; do not reuse the compromised mnemonic.
+ Environment: Record the words offline on a trusted device; never enter them on untrusted websites or apps.
+</Aside> [HIGH] Missing safety callout for funds transferLocation: docs/ecosystem/wallet-apps/web.mdx Lines 242 to 251 in 3c04b3b
Description: Suggestion: --- a/ecosystem/wallet-apps/web.mdx
+++ b/ecosystem/wallet-apps/web.mdx
@@
### Send the first transaction
+
+<Aside type="danger" title="Funds at risk">
+ This step transfers funds.
+ Scope: the selected wallet/account.
+ Environment: uses Testnet by default. Prefer Testnet for experiments.
+ Rollback: on-chain transfers are irreversible; verify the recipient and amount before sending.
+ If you must use mainnet, double-check fees, recipient, and amount. There is no rollback on mainnet.
+</Aside>
@@
In this example, we send TON to the account itself on Testnet to observe the transaction and wallet deployment on-chain. [HIGH] Secrets shown in example image (mnemonic words)Location: docs/ecosystem/wallet-apps/web.mdx Lines 84 to 88 in 3c04b3b
Description: Suggestion: -<Image
- src="/resources/images/wallets/wallet-ton-org/secret_words_light.png"
- darkSrc="/resources/images/wallets/wallet-ton-org/secret_words_dark.png"
- alt="24 Secret words"
-/>
+<Image
+ src="/resources/images/wallets/wallet-ton-org/secret_words_light_redacted.png"
+ darkSrc="/resources/images/wallets/wallet-ton-org/secret_words_dark_redacted.png"
+ alt="Recovery words (redacted)"
+/> |
closes #138