Skip to content

Conversation

aigerimu
Copy link
Contributor

closes #663

Copy link

Thanks for the update to the highload wallet spec. One small docs fix is needed before merge.

Findings (1)

High (1)

[HIGH] Diagram removed; note still references “step 8/9”

Location:

<Image
src="/resources/images/wallets/msg_flow_light.svg"
darkSrc="/resources/images/wallets/msg_flow_dark.svg"
alt="Message sending flow"
/>

Description:
The ASCII flow with numbered steps was removed and replaced by an <Image> at these lines, but the adjacent note still says “Message validation (step 9) happens after commit (step 8)” at standard/wallets/highload/v3/specification.mdx?plain=1#L465-L471. This leaves dangling references to undefined step numbers and reduces clarity in a safety‑critical sequence.

Suggestion:
Remove the step numbers from the note to avoid dangling references after the diagram replacement.

-  **Critical detail:** Message validation (step 9) happens **after commit** (step 8) to prevent infinite retries of invalid messages by lite-servers.
+  **Critical detail:** Message validation happens **after commit** to prevent infinite retries of invalid messages by lite-servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wallets > Highload wallet] Provide image for "Message sending flow" Review all illustrations and screenshots

1 participant