You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in ticket #17, I am sending you a proposal for a refactored template for the ServiceLocator implementation. The enum represents the necessary singleton implementation. To ensure backward compatibility, I have mapped the static methods internally to the singleton instance. Alternatively, you can also choose a different pattern for a singleton. Since I don't have your codestyle, the template might have to be reformatted. Line length here is 120 characters.
Furthermore, I noticed that after setting the classloader the cache was not cleared. I have implemented this at the same time.
thanks for the PR. I have nearly finished the APTK migration to Java 8.
I am going to update the whole project first and then merge your PR afterwards.
This is going to happen somewhen until the end of the week.
Java 8 based APTK version 0.20.0 has been released now.
It also includes the interface support for AnnotationWrappers, so i will likely able to add that server aliases pretty soon.
I have also prepared the upgrade of this project to Java 8 and will submit it once APTK version can be loaded from Maven central.
So i hope i will be able to merge your request today or tomorrow
Java 8 based APTK version 0.20.0 has been released now.
It also includes the interface support for AnnotationWrappers, so i will likely able to add that server aliases pretty soon.
I have also prepared the upgrade of this project to Java 8 and will submit it once APTK version can be loaded from Maven central.
So i hope i will be able to merge your request today or tomorrow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tobias,
As discussed in ticket #17, I am sending you a proposal for a refactored template for the ServiceLocator implementation. The enum represents the necessary singleton implementation. To ensure backward compatibility, I have mapped the static methods internally to the singleton instance. Alternatively, you can also choose a different pattern for a singleton. Since I don't have your codestyle, the template might have to be reformatted. Line length here is 120 characters.
Furthermore, I noticed that after setting the classloader the cache was not cleared. I have implemented this at the same time.
The code now requires JDK8.
Docu is adapted.
BR,
Tiemo