Adds expiration date to viewports #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbabej
force-pushed
the
master
branch
9 times, most recently
from
b549521 to
36652d1
Compare
Contributor
Author
|
This PR is also ready for review. |
Contributor
Author
|
Do you know what the error is about? It comes from the test suite I think, not my code. |
Collaborator
|
Looks like the develop branch of taskwarrior introduced changes (notably the new rust storage backend) that no longer build using the Dockerfiles we have here. It's just that one job so it's safe to ignore. |
Contributor
Author
|
OK, thanks for the info. There are some edge cases in this PR that I would like to have tests for, I will mark this PR as ready when I've done so. |
Owner
|
I like this idea! I rebased this locally and it's now present in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to expire viewports:
This will instruct taskwiki to not update the viewport after the expiration date
2020-10-10.This is useful for archiving files that contain taskwiki lists. If the user opens them after the expiration date, their content will not be altered.
The syntax is an exclamation mark followed by a date. Using sth like
expires:2020-01-01may not be desirable, since it can conflict with a UDA named expires.