Skip to content

Remove unnecessary double slashes#69

Merged
jpbberry merged 2 commits into
top-gg-community:masterfrom
Pacmard:patch-1
Aug 7, 2021
Merged

Remove unnecessary double slashes#69
jpbberry merged 2 commits into
top-gg-community:masterfrom
Pacmard:patch-1

Conversation

@Pacmard
Copy link
Copy Markdown
Contributor

@Pacmard Pacmard commented Aug 7, 2021

The request method already has a / in front of the PATH which is passed by other methods. Passing an additional slash at the beginning of the PATH for a request from a function is not required

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 7, 2021

✔️ Deploy Preview for topgg-node-sdk-docs ready!

🔨 Explore the source changes: 8845f29

🔍 Inspect the deploy log: https://app.netlify.com/sites/topgg-node-sdk-docs/deploys/610ead99eed4da00078fc8d2

😎 Browse the preview: https://deploy-preview-69--topgg-node-sdk-docs.netlify.app

@jpbberry
Copy link
Copy Markdown
Member

jpbberry commented Aug 7, 2021

Make this the other way around. I prefer the / be at the beginning when using the request method because it looks like a path. You just have to remove the existing / from the existing request method. e.g .request(“GET”, “/bot/stats”)

@Pacmard
Copy link
Copy Markdown
Contributor Author

Pacmard commented Aug 7, 2021

Understandable, done

@Pacmard Pacmard closed this Aug 7, 2021
@jpbberry jpbberry reopened this Aug 7, 2021
@jpbberry jpbberry merged commit 924f089 into top-gg-community:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants