Fixed all review feedbacks

Author: smtryingcode

app/directives/distribution-graph/distribution-graph.directive.js

@@ -216,8 +216,6 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
            $scope.highlightedRating = d.start
            $scope.displayCoders = true
            $scope.numCoders = d.number
-           $scope.$digest()
-           
            d3.select('#chart-tooltip')
               .style('left', (d3.event.pageX-4) + 'px')    
               .style('top', (d3.event.pageY-4) + 'px')
@@ -235,6 +233,7 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
            d3.select('#chart-tooltip .challenge-date').text('Rating Range: '+ $scope.highlightedRating + '-'+($scope.highlightedRating+99))
            d3.select('#chart-tooltip .tooltip-rating').text($scope.numCoders)
            d3.select('#chart-tooltip .tooltip-rating').style('background', ratingToColor($scope.colors, $scope.highlightedRating))
+           $scope.$digest()
          })
          .on('mousemove', function(d) {
            window.clearTimeout(mousemoveInterval)

app/directives/history-graph/history-graph.directive.js

@@ -19,11 +19,11 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
         rating: '=',
         graphState: '='
       },
-      controller: ['$scope', '$state', '$window', 'CONSTANTS', HistoryGraphController]
+      controller: ['$scope', '$state', 'CONSTANTS', HistoryGraphController]
     }
   }
 
-  function HistoryGraphController($scope, $state, $window, CONSTANTS) {
+  function HistoryGraphController($scope, $state, CONSTANTS) {
     $scope.colors = [
       // grey
       {
@@ -275,14 +275,13 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
            $scope.historyRating = d.newRating
            $scope.historyDate = moment(d.ratingDate).format('YYYY-MM-DD')
            $scope.historyChallenge = d.challengeName
-           $scope.$digest()
            $('#chart-tooltip .tooltip-container').on('click', function(){
-             if($state.params && $state.params.track === 'DEVELOP')
-               $window.open(CONSTANTS.CHALLENGE_DETAIL_URL + d.challengeId + '/?type=develop', '_blank')
+             if($state.params && $state.params.track === 'DEVELOP', '_self')
+               location.href = (CONSTANTS.CHALLENGE_DETAIL_URL + d.challengeId + '/?type=develop')
              else if($state.params && $state.params.subTrack === 'SRM')
-               $window.open(CONSTANTS.SRM_DETAIL_URL + d.challengeId, '_blank')
+               location.href = (CONSTANTS.SRM_DETAIL_URL + d.challengeId, '_self')
              else if($state.params && $state.params.subTrack === 'MARATHON_MATCH')
-               $window.open(CONSTANTS.MARATHON_DETAIL_URL + d.challengeId, '_blank')
+               location.href = (CONSTANTS.MARATHON_DETAIL_URL + d.challengeId, '_self')
            })           
            d3.select('#chart-tooltip')
               .style('left', (d3.event.pageX-5) + 'px')    
@@ -298,21 +297,20 @@ import Tooltip from 'appirio-tech-react-components/components/Tooltip/Tooltip.js
            d3.select('#chart-tooltip .challenge-date').text(moment(d.ratingDate).format('MMM DD, YYYY'))
            d3.select('#chart-tooltip .tooltip-rating').text($scope.historyRating)
            d3.select('#chart-tooltip .tooltip-rating').style('background', ratingToColor($scope.colors, $scope.historyRating))
-         
+           $scope.$digest()
          })
          .on('mouseout', function(d) {
            $scope.historyRating = undefined
-           $scope.$digest()
            $('#chart-tooltip').off('click')
+           $scope.$digest()
          })
 
       d3.select('body').on('click', function(){
         if((d3.event.target.classList[0] != 'tooltip-target') && !$('#chart-tooltip .tooltip-container').hasClass('tooltip-hide') &&
           (d3.event.target.classList[0] != 'tooltip-content-container') && (d3.event.target.classList[0] != 'tooltip-container') &&
           (d3.event.target.classList[0] != 'tooltip-body') && (d3.event.target.classList[0] != 'Tooltip') &&
           (d3.event.target.tagName.toLowerCase()!='circle') && !(d3.event.target.tagName.toLowerCase()=='rect' && d3.event.target.classList[0] == 'hover')) {
-          $('#chart-tooltip .tooltip-container').addClass('tooltip-hide')
-          $('#chart-tooltip .tooltip-container').css('opacity', 0)
+          $('#chart-tooltip .tooltip-target').trigger('click')
         }
       })