This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/mailchimp api preference api #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 10, 2016 18:22
… preferences service -- Adapted code to use the refactored api
* dev: AS#118090147171048, Mail chimp Integration Conflicts: app/settings/email/email.controller.js
… preferences service -- Fixed new service reference in tests
… preferences service -- Fixed new service reference in tests
… preferences service -- Adapted calling code for express based preference API
* dev: AS#125999129126033, 1 Million users hero banner on Dashboard AS#125999129126033, 1 Million users hero banner on Dashboard Updated contact us link
| case 'USER': | ||
| return _getRestangularV3(CONSTANTS.AUTH_API_URL) | ||
| case 'MAILCHIMP': | ||
| case 'PREFERENCES': |
Contributor
There was a problem hiding this comment.
Shouldn't this point to API_URL (api.topcoder.com) instead?
Contributor
Author
There was a problem hiding this comment.
Yes, you are correct. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah fyi
The PR includes the changes needed to adapt the frontend for the preferences based API instead of mailchimp API wrapper.