When checking m2m scopes - one scope match is enough #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .filter(Boolean); | ||
|
|
||
| const ok = required.every((s) => scopes.includes(s)); | ||
| const ok = required.some((s) => scopes.includes(s)); |
There was a problem hiding this comment.
[security]
The change from every to some is consistent with the pull request description, allowing for any one of the required scopes to be sufficient for authorization. Ensure that this change aligns with the intended security model, as it may allow access with fewer permissions than previously required.
jmgasper
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scopes check for m2m call - one scope match is enough.
Eg. I'm calling with a token that has onle
update:billing-account, while the controller lists for scopes bothupdate:billing-accountandall:billing-account, the call was failing because I'm missing the "all" scope.