Automate migrations #41
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docker/Dockerfile
Outdated
|
|
||
| RUN mkdir -p /challenge-api/reports | ||
|
|
||
| RUN echo "Running database migrations..." |
There was a problem hiding this comment.
[performance]
Combining the echo command with the npx prisma migrate deploy command into a single RUN statement can reduce the number of layers in the Docker image, which can improve build performance and reduce image size. Consider using RUN echo "Running database migrations..." && npx prisma migrate deploy.
docker/Dockerfile
Outdated
| RUN mkdir -p /challenge-api/reports | ||
|
|
||
| RUN echo "Running database migrations..." | ||
| RUN npx prisma migrate deploy |
There was a problem hiding this comment.
[❗❗ correctness]
Running database migrations automatically when the container starts can lead to potential issues if multiple instances of the container are started simultaneously, as they might attempt to run migrations concurrently. Consider implementing a locking mechanism or ensuring that only one instance handles migrations to avoid race conditions.
|
|
||
| CMD ["node","/challenge-api/app.js"] | ||
| # Copy entrypoint script and make it executable | ||
| COPY docker/entrypoint.sh /entrypoint.sh |
There was a problem hiding this comment.
[❗❗ correctness]
Ensure that the entrypoint.sh script handles errors gracefully, especially during migrations. This is crucial to prevent the container from entering a crash loop if migrations fail.
|
|
||
| # Start the application | ||
| echo "Starting application server..." | ||
| exec node /challenge-api/app.js |
There was a problem hiding this comment.
[💡 design]
Using exec to start the application server is a good practice as it replaces the shell with the node process, ensuring that the process receives signals directly. Ensure that this behavior is intended.
Running migrations automatically when service starts.