Allow for Topgear Submission type phase when calculating start / end dates (PS-444) #47
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const { ensureAcessibilityToModifiedGroups } = require("./group-helper"); | ||
| const { ChallengeStatusEnum } = require("@prisma/client"); | ||
|
|
||
| const SUBMISSION_PHASE_PRIORITY = ["Topcoder Submission", "Submission"]; |
There was a problem hiding this comment.
[performance]
Consider using a Set for SUBMISSION_PHASE_PRIORITY to improve lookup performance when checking phase names. This change can enhance performance, especially if the list grows or is checked frequently.
| const registrationPhase = _.find(challenge.phases, (p) => p.name === "Registration"); | ||
| const submissionPhase = _.find(challenge.phases, (p) => p.name === "Submission"); | ||
| const submissionPhase = | ||
| _.find(challenge.phases, (p) => p.name === SUBMISSION_PHASE_PRIORITY[0]) || |
There was a problem hiding this comment.
[maintainability]
The current logic assumes that only the first two elements in SUBMISSION_PHASE_PRIORITY will be checked. If more submission types are added in the future, this logic will need to be updated. Consider iterating over SUBMISSION_PHASE_PRIORITY to make the code more maintainable and adaptable to future changes.
|
|
||
| const registrationPhase = _.find(phases, (p) => p.name === "Registration"); | ||
| const submissionPhase = | ||
| _.find(phases, (p) => p.name === SUBMISSION_PHASE_PRIORITY[0]) || |
There was a problem hiding this comment.
[maintainability]
The logic for finding the submissionPhase relies on the order of SUBMISSION_PHASE_PRIORITY. If more submission types are added in the future, this logic will need to be updated. Consider using a more flexible approach, such as iterating through SUBMISSION_PHASE_PRIORITY and finding the first match.
https://topcoder.atlassian.net/browse/PS-444