login page and misc updates #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It contains a bunch of updates around the codebase, as it seems that the new version of ESLint and AirBnB ESLint config use somewhat different rules for code indendation in some cases.
Submission 240807 by mak17394 to the challenge http://www.topcoder.com/challenge-details/30058449/?type=develop
Originally, there was a need for a quick fix to ensure that buttons (Register / Unregister, Submit, etc.) in the upper part of the New Challenge Details page work properly. As it turned out, the markup and SCSS styling around these buttons is messy, there was a need to refactor related styling; in turn it was noted that some related global SCSS styles are messy. Thus, it resulted in quite a large fix, and the actual fix of the New Challenge Details page will be in the follow-up commit. In global SCSS styles: - _tc-includes.scss was removed (it had just two imports, which were moved directly to _tc-styles, to avoid confusion, which one of them should be typically imported into .scss files); - mixins/_media.scss was enhanced in few ways: (a) breakpoint constants were moved into _variables.scss (actually, they were already defined there, but with different values, and were not used anywhere in code - thus, this change ensures consistency); (b) few new media mixins were added; (c) ensures that for all mixins the name A-to-B means "the sizes from A to B, both inclusive". - slight modification of color values in _variables.scss: some of the color values were slightly different from the values stated on Topcoder Brand Guidelines page (https://www.topcoder.com/about-topcoder/brand-guidelines/), they were updated to match. New Challenge Details page: - Custom colors replaced by close colors already present in _variables.scss
The new button component(s) allows to create buttons and button-like links in a convenient and consistent way. It also allows to style such buttons using react-css-themr. See the demo at /examples/buttons/ endpoint
Now register / unregister / submit buttons work properly. View Submission button also should work, but it is not possible to test at the moment, as Submission Management Page is temporarly broken.
This commit mostly fixes the problem (there are still a few minor styling problems, to be handled separately). Fixes #130
for a better consistency with other ones, and also as a part of fix for Submissions Management Page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.