Skip to content

fixed #366 passing domain for user profiles avatar #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2017
Merged

fixed #366 passing domain for user profiles avatar #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b9d33
fixed #366 passing domain for user profiles avatar
shubhendusaurabh Aug 28, 2017
b577ef7
get domain via config not props
shubhendusaurabh Aug 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/shared/components/LeaderboardAvatar/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// TODO: All uses of this component MUST be replaced by Avatar component!

import config from 'utils/config';
import React, { Component } from 'react';
import PT from 'prop-types';
import './style.scss';
Expand All @@ -25,9 +26,9 @@ class LeaderboardAvatar extends Component {
}

render() {
const { domain, openNewTab, url } = this.props;
const { openNewTab, url } = this.props;
const { member } = this.state;
const targetURL = url || `//${domain}/members/${member.handle}`;
const targetURL = url || `${config.URL.BASE}/members/${member.handle}`;
return (
<a
href={targetURL}
Expand All @@ -50,14 +51,12 @@ class LeaderboardAvatar extends Component {
}

LeaderboardAvatar.defaultProps = {
domain: process.env.domain,
member: {},
openNewTab: false,
url: '',
};

LeaderboardAvatar.propTypes = {
domain: PT.string,
member: PT.shape({}),
openNewTab: PT.bool,
url: PT.string,
Expand Down