Skip to content

fix: issue #5800 #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

fix: issue #5800 #5816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/shared/components/Settings/Account/LinkedAccount/AddWebLink.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default class AddWebLink extends React.Component {
super(props);
this.state = {
webLink: '',
webLinkEmpty: false,
};

this.onUpdateWebLink = this.onUpdateWebLink.bind(this);
Expand All @@ -32,6 +33,11 @@ export default class AddWebLink extends React.Component {
// Set web link
onUpdateWebLink(e) {
e.preventDefault();
if (e.target.value) {
this.setState({
webLinkEmpty: false,
});
}
this.setState({ webLink: e.target.value });
}

Expand Down Expand Up @@ -62,6 +68,11 @@ export default class AddWebLink extends React.Component {
tokenV3,
} = this.props;
const { webLink } = this.state;
if (!webLink) {
this.setState({
webLinkEmpty: true,
});
}
if (webLink && this.isWebLinkValid() && !this.webLinkExist()) {
addWebLink(handle, tokenV3, webLink);
}
Expand All @@ -82,7 +93,7 @@ export default class AddWebLink extends React.Component {
}

render() {
const { webLink } = this.state;
const { webLink, webLinkEmpty } = this.state;

const webLinkValid = this.isWebLinkValid();
const webLinkExist = this.webLinkExist();
Expand Down Expand Up @@ -172,6 +183,15 @@ export default class AddWebLink extends React.Component {
onKeyDown={this.onAddWebLink}
required
/>
{
webLinkEmpty && (
<div styleName="form-input-error">
<p>
Please Enter External Link
</p>
</div>
)
}
{
!webLinkValid && !webLinkExist
&& (
Expand Down