Ranking fix for MM finals 2025 #7143
Merged
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const normalizedScore = normalizeScoreValue(_.get(summation, 'aggregateScore')); | ||
| const isProvisional = Boolean(summation.isProvisional); | ||
| const isLatest = _.isNil(summation.isLatest) ? true : Boolean(summation.isLatest); | ||
| const isLatest = _.isNil(summation.isLatest) ? null : Boolean(summation.isLatest); |
There was a problem hiding this comment.
[❗❗ correctness]
The change from true to null as the default value for isLatest alters the logic significantly. Ensure that this change is intentional and that all dependent logic correctly handles null values.
| })) | ||
| .sort((a, b) => toTimestampValue(b.submissionTime) - toTimestampValue(a.submissionTime)); | ||
|
|
||
| const hasLatestFlag = submissions.some(s => !_.isNil(s.isLatest)); |
There was a problem hiding this comment.
[❗❗ correctness]
The logic for determining latestSubmissions now relies on the presence of the isLatest flag. Ensure that all submissions have this flag set appropriately, as missing or incorrect flags could lead to incorrect ranking calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.