Skip to content

Issues-389: show 'Home' in the breadcrumbs #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Issues-389: show 'Home' in the breadcrumbs #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vanilla/applications/vanilla/controllers/class.draftscontroller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public function index($offset = '0') {
$this->addJsFile('jquery.gardenmorepager.js');
$this->addJsFile('discussions.js');
$this->title(t('My Drafts'));
$this->setData('Breadcrumbs', [['Name' => t('My Drafts'), 'Url' => '/drafts']]);

// Validate $Offset
if (!is_numeric($offset) || $offset < 0) {
Expand Down
3 changes: 1 addition & 2 deletions vanilla/library/SmartyPlugins/function.breadcrumbs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ function smarty_function_breadcrumbs($params, &$smarty) {

$options = arrayTranslate($params, ['homeurl' => 'HomeUrl', 'hidelast' => 'HideLast']);

// Don't show a home link by default
return Gdn_Theme::breadcrumbs($breadcrumbs, val('homelink', $params, false), $options);
return Gdn_Theme::breadcrumbs($breadcrumbs, val('homelink', $params, true), $options);
}
7 changes: 1 addition & 6 deletions vanilla/library/core/class.theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public static function assetEnd() {
* @param array $options
* @return string
*/
public static function breadcrumbs($data, $homeLink = false, $options = []) {
public static function breadcrumbs($data, $homeLink = true, $options = []) {
$format = '<a href="{Url,html}" itemprop="url"><span itemprop="title">{Name,html}</span></a>';

$result = '';
Expand Down Expand Up @@ -87,11 +87,6 @@ public static function breadcrumbs($data, $homeLink = false, $options = []) {

$defaultRoute = ltrim(val('Destination', Gdn::router()->getRoute('DefaultController'), ''), '/');

// FIX: Don't show current page
if(count($data) <= 1) {
return '';
}

$count = 0;
$dataCount = 0;
$homeLinkFound = false;
Expand Down