Skip to content

[HOTIFX] [DEV] consistent project data validation rules #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2019
Merged

[HOTIFX] [DEV] consistent project data validation rules #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/ProcessorService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,8 @@ processCreate.schema = {
payload: joi.object().keys({
resource: joi.string().required(),
id: joi.numberId(),
name: joi.string().max(200).required(),
description: joi.string().max(10000).allow('').allow(null).required(),
name: joi.string().required(),
description: joi.string().allow(null).allow('').optional(),
directProjectId: joi.optionalNumberId().allow(null),
billingAccountId: joi.optionalNumberId().allow(null),
type: joi.string().max(45).required(),
Expand Down
18 changes: 0 additions & 18 deletions test/processor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,24 +759,6 @@ describe('Topcoder - Legacy Project Processor E2E Test', () => {
}

if (op === 'create') {
it(`test invalid parameters, string field name too long`, async () => {
let message = _.cloneDeep(testMessages[0])
_.set(message, 'payload.name', 'a'.repeat(201))
await sendMessage(message)
await waitJob()

assertErrorMessage(`"name" length must be less than or equal to 200 characters long`)
})

it(`test invalid parameters, string field description too long`, async () => {
let message = _.cloneDeep(testMessages[0])
_.set(message, 'payload.description', 'a'.repeat(10001))
await sendMessage(message)
await waitJob()

assertErrorMessage(`"description" length must be less than or equal to 10000 characters long`)
})

it(`test invalid parameters, string field type too long`, async () => {
let message = _.cloneDeep(testMessages[0])
_.set(message, 'payload.type', 'a'.repeat(46))
Expand Down
2 changes: 1 addition & 1 deletion test/testData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const testTopics = {
create: {
requiredFields: ['originator', 'timestamp', 'mime-type',
'payload.id', 'payload.name', 'payload.description', 'payload.type', 'payload.createdBy'],
'payload.id', 'payload.name', 'payload.type', 'payload.createdBy'],
stringFields: ['payload.name', 'payload.description', 'payload.type'],
integerFields: ['payload.id', 'payload.directProjectId', 'payload.billingAccountId', 'payload.createdBy'],
testMessages: [
Expand Down