Better handling of basic_trait info #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| await updateMembersWithTraitsAndSkills(traitUpdate) | ||
| updated += 1 | ||
| const updatedSuccessfully = await updateMembersWithTraitsAndSkills(traitUpdate) |
There was a problem hiding this comment.
[correctness]
The function updateMembersWithTraitsAndSkills is expected to return a truthy value indicating success. Ensure that this function consistently returns a boolean or a value that can be reliably interpreted as success or failure. This will prevent potential logical errors if the function's return value changes in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic-info updating for slightly missing values in certain old data, and step to migration to update only this trait exactly.