Better handling of slightly messy prod data #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (value instanceof Date) { | ||
| return value | ||
| } | ||
| if (typeof value === 'object') { |
There was a problem hiding this comment.
[correctness]
Using _.mapValues on an object without checking for circular references can lead to a stack overflow error if the object contains circular references. Consider adding a check to handle such cases.
| result = _.filter(result, (item) => _.includes(config.MEMBER_PUBLIC_TRAITS, item.traitId)) | ||
| } | ||
| return result | ||
| return helper.convertBigIntDeep(result) |
There was a problem hiding this comment.
[correctness]
The function helper.convertBigIntDeep(result) is used to convert BigInt values deeply within the result object. Ensure that this conversion is necessary for all elements within result and that helper.convertBigIntDeep handles all edge cases correctly, especially if result can contain nested structures or unexpected data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.