Skip to content

Better handling of slightly messy prod data #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Better handling of slightly messy prod data #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef4215
Better handling of slightly messy prod data
jmgasper Nov 2, 2025
9fe712c
Merge pull request #16 from topcoder-platform/migration
jmgasper Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/common/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,25 @@ function bigIntToNumber (value) {
return null
}

function convertBigIntDeep (value) {
if (value === null || value === undefined) {
return value
}
if (typeof value === 'bigint') {
return bigIntToNumber(value)
}
if (Array.isArray(value)) {
return value.map(convertBigIntDeep)
}
if (value instanceof Date) {
return value
}
if (typeof value === 'object') {
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Using _.mapValues on an object without checking if it's a plain object can lead to unexpected behavior if value is an instance of a class or has a prototype chain. Consider using _.isPlainObject to ensure value is a plain object before mapping its values.

return _.mapValues(value, convertBigIntDeep)
}
return value
}

module.exports = {
wrapExpress,
autoWrapExpress,
Expand Down Expand Up @@ -591,5 +610,6 @@ module.exports = {
getParamsFromQueryAsArray,
secureMemberAddressData,
truncateLastName,
bigIntToNumber
bigIntToNumber,
convertBigIntDeep
}
2 changes: 1 addition & 1 deletion src/services/MemberTraitService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ async function getTraits (currentUser, handle, query) {
if (!currentUser) {
result = _.filter(result, (item) => _.includes(config.MEMBER_PUBLIC_TRAITS, item.traitId))
}
return result
return helper.convertBigIntDeep(result)
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Ensure that helper.convertBigIntDeep is correctly handling all possible data structures within result. If result contains nested objects or arrays, verify that convertBigIntDeep can process them without errors or unintended modifications.

}

getTraits.schema = {
Expand Down
Loading