Skip to content

Commit 1824915

Browse files
authored
Merge pull request #251 from topcoder-platform/PROD-2754_mobile-download-certificate
PROD-2754 - fix mobile download certificate
2 parents 97ab03c + d7b9150 commit 1824915

File tree

9 files changed

+41
-6
lines changed

9 files changed

+41
-6
lines changed

src-ts/tools/learn/course-certificate/certificate-view/certificate/course-card/CourseCard.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
}
1616

1717
.badge {
18-
svg {
18+
img {
1919
display: block;
2020
@include icon-size(78);
2121
}

src-ts/tools/learn/course-certificate/certificate-view/certificate/course-card/CourseCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const CourseCard: FC<CourseCardProps> = (props: CourseCardProps) => {
1818
<div className={styles['wrap']}>
1919
<div className={styles['top-wrap']}>
2020
<div className={styles['badge']}>
21-
<CourseBadge type={props.type} />
21+
<CourseBadge type={props.type} asImg />
2222
</div>
2323
<h5 className={classNames('details', styles['course-title'])}>
2424
{props.course}

src-ts/tools/learn/learn-lib/course-badge/CourseBadge.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,23 @@
1-
import { FC } from 'react'
1+
import { FC, SVGProps } from 'react'
22

33
import { LearnCertificateTrackType } from '../all-certifications-provider'
44

5-
import { getBadge } from './badges.functions'
5+
import { getBadge, getBadgeImg } from './badges.functions'
66
import styles from './CourseBadge.module.scss'
77

88
interface CourseBadgeProps {
9+
asImg?: boolean
910
type: LearnCertificateTrackType
1011
}
1112

1213
const CourseBadge: FC<CourseBadgeProps> = (props: CourseBadgeProps) => {
13-
const Badge: ReturnType<typeof getBadge> = getBadge(props.type)
14+
if (props.asImg) {
15+
const badgeImg: string = getBadgeImg(props.type)
16+
return (
17+
<img src={badgeImg} alt={props.type} />
18+
)
19+
}
20+
const Badge: FC<SVGProps<SVGSVGElement>> = getBadge(props.type)
1421

1522
return (
1623
<div className={styles['wrap']}>
Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
import { FC, SVGProps } from 'react'
22

3-
import { DataScienceBadge, DesignBadge, DevelopBadge, QABadge } from './badges'
3+
import {
4+
DataScienceBadge,
5+
DataScienceBadgeImg,
6+
DesignBadge,
7+
DesignBadgeImg,
8+
DevelopBadge,
9+
DevelopBadgeImg,
10+
QABadge,
11+
QABadgeImg,
12+
} from './badges'
413

514
const badgesMap: {[key: string]: FC<SVGProps<SVGSVGElement>>} = {
615
DATASCIENCE: DataScienceBadge,
@@ -9,6 +18,17 @@ const badgesMap: {[key: string]: FC<SVGProps<SVGSVGElement>>} = {
918
QA: QABadge,
1019
}
1120

21+
const badgesImgMap: {[key: string]: string} = {
22+
DATASCIENCE: DataScienceBadgeImg,
23+
DESIGN: DesignBadgeImg,
24+
DEV: DevelopBadgeImg,
25+
QA: QABadgeImg,
26+
}
27+
1228
export function getBadge(badgeType: keyof typeof badgesMap): FC<SVGProps<SVGSVGElement>> {
1329
return badgesMap[badgeType]
1430
}
31+
32+
export function getBadgeImg(badgeType: keyof typeof badgesMap): string {
33+
return badgesImgMap[badgeType]
34+
}
26.3 KB
Loading
24.1 KB
Loading
25 KB
Loading
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
1+
import DataScienceBadgeImg from './datascience-badge.png'
12
import { ReactComponent as DataScienceBadge } from './datascience-badge.svg'
3+
import DesignBadgeImg from './design-badge.png'
24
import { ReactComponent as DesignBadge } from './design-badge.svg'
5+
import DevelopBadgeImg from './develop-badge.png'
36
import { ReactComponent as DevelopBadge } from './develop-badge.svg'
7+
import QABadgeImg from './qa-badge.png'
48
import { ReactComponent as QABadge } from './qa-badge.svg'
59

610
export {
711
DataScienceBadge,
812
DesignBadge,
913
DevelopBadge,
1014
QABadge,
15+
DataScienceBadgeImg,
16+
DesignBadgeImg,
17+
DevelopBadgeImg,
18+
QABadgeImg,
1119
}
26 KB
Loading

0 commit comments

Comments
 (0)