Skip to content

PROD-2754 - fix mobile download certificate #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2022
Merged

PROD-2754 - fix mobile download certificate #251

merged 2 commits into from
Aug 3, 2022

Conversation

@vas3a
Copy link
Collaborator

@vas3a vas3a commented Aug 3, 2022

PROD-2754

Fix for user certificate download on iPhone/safari.

  • I kept both versions of the badge logos: svg & png.
  • only the certificate is using the png versions of the badges (svg is far better than PNG so use svg wherever we can)

@vas3a vas3a self-assigned this Aug 3, 2022
testflyjets
testflyjets approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vas3a vas3a merged commit 1824915 into dev Aug 3, 2022
@vas3a vas3a deleted the PROD-2754_mobile-download-certificate branch August 3, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brooketopcoder brooketopcoder Awaiting requested review from brooketopcoder

1 more reviewer

@testflyjets testflyjets testflyjets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vas3a vas3a

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vas3a @testflyjets