Skip to content

Commit cdd9899

Browse files
authored
Merge pull request #1352 from topcoder-platform/PM-3091_clear-review-cache
PM-3091 - clear review cache
2 parents 21331e0 + 32440d7 commit cdd9899

File tree

1 file changed

+23
-25
lines changed
  • src/apps/review/src/lib/components/Scorecard/ScorecardViewer/hooks

1 file changed

+23
-25
lines changed

src/apps/review/src/lib/components/Scorecard/ScorecardViewer/hooks/useReviewForm.ts

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -41,32 +41,30 @@ export const useReviewForm = ({
4141
}, [isDirty, onFormChange])
4242

4343
useEffect(() => {
44-
if (reviewItems?.length) {
45-
const newFormData = {
46-
reviews: reviewItems.map(
47-
(reviewItem, reviewItemIndex) => ({
48-
comments: 'reviewItemComments' in reviewItem ? reviewItem.reviewItemComments?.map(
49-
(commentItem, commentIndex) => ({
50-
content: commentItem.content ?? '',
51-
id: commentItem.id,
52-
index: commentIndex,
53-
type: commentItem.type ?? '',
54-
}),
55-
) : [],
56-
id: reviewItem.id,
57-
index: reviewItemIndex,
58-
initialAnswer: (
59-
('finalAnswer' in reviewItem && reviewItem.finalAnswer)
60-
|| ('initialAnswer' in reviewItem && reviewItem.initialAnswer)
61-
|| ('questionScore' in reviewItem && reviewItem.questionScore)
62-
|| undefined
63-
) as string,
64-
scorecardQuestionId: reviewItem.scorecardQuestionId,
65-
}),
66-
),
67-
}
68-
reset(newFormData)
44+
const newFormData = {
45+
reviews: (reviewItems ?? []).map(
46+
(reviewItem, reviewItemIndex) => ({
47+
comments: 'reviewItemComments' in reviewItem ? reviewItem.reviewItemComments?.map(
48+
(commentItem, commentIndex) => ({
49+
content: commentItem.content ?? '',
50+
id: commentItem.id,
51+
index: commentIndex,
52+
type: commentItem.type ?? '',
53+
}),
54+
) : [],
55+
id: reviewItem.id,
56+
index: reviewItemIndex,
57+
initialAnswer: (
58+
('finalAnswer' in reviewItem && reviewItem.finalAnswer)
59+
|| ('initialAnswer' in reviewItem && reviewItem.initialAnswer)
60+
|| ('questionScore' in reviewItem && reviewItem.questionScore)
61+
|| undefined
62+
) as string,
63+
scorecardQuestionId: reviewItem.scorecardQuestionId,
64+
}),
65+
),
6966
}
67+
reset(newFormData)
7068
}, [reviewItems, reset])
7169

7270
const touchedAllFields = useCallback(() => {

0 commit comments

Comments
 (0)