Fix for winner tab display #1281
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Find all submissions for this member | ||
| const memberSubmissions = submissions.filter(s => s.memberId === memberId) | ||
| const contestSubmissions = memberSubmissions.filter( | ||
| submission => (submission.type ?? SUBMISSION_TYPE_CONTEST) === SUBMISSION_TYPE_CONTEST, |
There was a problem hiding this comment.
[correctness]
The use of the nullish coalescing operator (??) here assumes that submission.type can be null or undefined. Ensure that this is the intended behavior and that submission.type is not expected to have other falsy values like an empty string.
| submission => (submission.type ?? SUBMISSION_TYPE_CONTEST) === SUBMISSION_TYPE_CONTEST, | ||
| ) | ||
|
|
||
| // Prefer contest submissions; fall back to everything so we still display something if data is inconsistent |
There was a problem hiding this comment.
[design]
The logic here prioritizes contest submissions over others. Ensure that this prioritization aligns with the business requirements and that non-contest submissions should indeed be considered only as a fallback.
|
|
||
| // Only expose contest submissions in the winners list | ||
| const contestWinners = winners.filter(winner => ( | ||
| (winner.type ?? SUBMISSION_TYPE_CONTEST) === SUBMISSION_TYPE_CONTEST |
There was a problem hiding this comment.
[correctness]
The use of the nullish coalescing operator (??) with winner.type assumes that winner.type can be null or undefined. Ensure that this is the intended behavior and that winner.type is not expected to have other falsy values like an empty string, which would bypass the defaulting to SUBMISSION_TYPE_CONTEST.
Winner tab display would sometimes show Checkpoint review scores and submission IDs, which was confusing