Skip to content

Have admin access be priority over resource role on challenge, and fix visibility of checkpoint submissions that fail screening #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

Have admin access be priority over resource role on challenge, and fix visibility of checkpoint submissions that fail screening #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/apps/review/src/lib/hooks/useFetchScreeningReview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,6 +1502,25 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
reviewEntries: reviewsToRender,
})

const hasCheckpointReview = rowsForSubmission.some(row => Boolean(row.reviewId))
Copy link

@github-actions github-actions bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The variable hasCheckpointReview is determined by checking if any row in rowsForSubmission has a reviewId. Ensure that rowsForSubmission is correctly populated with the expected data before this check, as any issues in data population could lead to incorrect logic execution.

const submissionStatus = (item.status ?? '')
.toString()
.trim()
.toUpperCase()
const failedCheckpointScreening = submissionStatus === 'FAILED_CHECKPOINT_SCREENING'
Copy link

@github-actions github-actions bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 maintainability]
The logic for determining failedCheckpointScreening relies on the status being exactly 'FAILED_CHECKPOINT_SCREENING'. Consider using a constant or enum for status values to avoid potential typos and improve maintainability.


if (failedCheckpointScreening && !hasCheckpointReview) {
Copy link

@github-actions github-actions bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ design]
The condition failedCheckpointScreening && !hasCheckpointReview results in an early return of rows. Ensure that this logic aligns with the intended behavior, as it skips adding rowsForSubmission to rows, which might be necessary for other parts of the application.

if (debugCheckpointPhases) {
debugLog('checkpointReview.skipSubmission', {
reason: 'failedCheckpointScreeningWithoutReview',
submissionId: item.id,
submissionStatus,
})
}

return rows
}

rows.push(...rowsForSubmission)

return rows
Expand Down
5 changes: 4 additions & 1 deletion src/apps/review/src/lib/hooks/useRole.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ const useRole = (): useRoleProps => {
return ''
}

const normalizedRoles = myRoles.map(role => role.toLowerCase())
const normalizedRoles = [
...myRoles.map(role => role.toLowerCase()),
...(isTopcoderAdmin ? ['admin'] : []),
Copy link

@github-actions github-actions bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The addition of admin to normalizedRoles when isTopcoderAdmin is true could potentially lead to a mismatch in role priority if the casing of roles is inconsistent elsewhere. Ensure that all role comparisons are case-insensitive to avoid unexpected behavior.

]
const rolePriority: ChallengeRole[] = [
'Admin',
'Manager',
Expand Down
Loading