Skip to content

PM-3072 - markdown for aiworkflow desc #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

PM-3072 - markdown for aiworkflow desc #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/apps/review/src/pages/reviews/components/AiModelModal/AiModelModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { FC } from 'react'
import { BaseModal } from '~/libs/ui'
import { AiWorkflow } from '~/apps/review/src/lib/hooks'
import { IconExternalLink } from '~/apps/review/src/lib/assets/icons'
import { MarkdownReview } from '~/apps/review/src/lib/components/MarkdownReview'

import AiModelIcon from '../AiModelIcon'

Expand Down Expand Up @@ -35,7 +36,7 @@ const AiModelModal: FC<AiModelModalProps> = props => (
</div>

<p className={styles.modelDescription}>
{props.model.description}
<MarkdownReview value={props.model.description} />
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Ensure that props.model.description is sanitized before rendering with MarkdownReview to prevent potential XSS vulnerabilities. If MarkdownReview handles sanitization internally, this can be ignored.

</p>
</div>
</BaseModal>
Expand Down
3 changes: 2 additions & 1 deletion src/apps/review/src/pages/reviews/components/ScorecardHeader/ScorecardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ReviewsContextModel } from '~/apps/review/src/lib/models'
import { useRolePermissions, UseRolePermissionsResult } from '~/apps/review/src/lib/hooks'
import { ArrowCircleDownIcon, ArrowCircleUpIcon } from '@heroicons/react/outline'

import { MarkdownReview } from '../../../../lib/components/MarkdownReview'
import { IconClock, IconFile, IconPremium } from '../../../../lib/assets/icons'
import { AiModelModal } from '../AiModelModal'
import { useReviewsContext } from '../../ReviewsContext'
Expand Down Expand Up @@ -105,7 +106,7 @@ const ScorecardHeader: FC = () => {
</div>
</div>
<p className={styles.workflowDescription}>
{workflow.description}
<MarkdownReview value={workflow.description} />
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Ensure that workflow.description is properly sanitized before being passed to MarkdownReview to prevent potential XSS vulnerabilities if description contains user-generated content.

</p>
{/* <div className={styles.workflowFileLink}>
<a href={workflow.defUrl}>
Expand Down
Loading