Skip to content

fix(PM-3090): likes dislikes not updated automatically #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 3 commits into from
Dec 1, 2025
Merged

fix(PM-3090): likes dislikes not updated automatically #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca06ce4
fix: likes dislikes not updated automatically
hentrymartin Nov 30, 2025
44c4edf
fix: likes dislikes not updated automatically
hentrymartin Nov 30, 2025
32c3ea6
fix: lint
hentrymartin Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../src/lib/components/Scorecard/ScorecardViewer/ScorecardQuestion/AiFeedback/AiFeedback.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ const AiFeedback: FC<AiFeedbackProps> = props => {
await createFeedbackComment(workflowId as string, workflowRun?.id as string, feedback?.id, {
content,
})
await mutate(`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items`)
await mutate(`
${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items?[${workflowRun?.status}]
`)
setShowReply(false)
}, [workflowId, workflowRun?.id, feedback?.id])

Expand Down
9 changes: 6 additions & 3 deletions ...nents/Scorecard/ScorecardViewer/ScorecardQuestion/AiFeedbackActions/AiFeedbackActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ export const AiFeedbackActions: FC<AiFeedbackActionsProps> = props => {
}

try {
const itemsKey = `${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items`
// eslint-disable-next-line max-len
const itemsKey = `${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items?[${workflowRun?.status}]`
Copy link

@github-actions github-actions bot Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The use of optional chaining with workflowRun?.status in the URL may lead to unexpected behavior if workflowRun is undefined. Consider ensuring workflowRun is defined before constructing the URL to avoid potential issues.

mutate(itemsKey, (items: any) => {
if (!items || !Array.isArray(items)) return items

Expand Down Expand Up @@ -202,7 +203,8 @@ export const AiFeedbackActions: FC<AiFeedbackActionsProps> = props => {
setUpVotes(prevUp)
setDownVotes(prevDown)

const itemsKey = `${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items`
// eslint-disable-next-line max-len
const itemsKey = `${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items?[${workflowRun?.status}]`
await mutate(itemsKey)
} finally {
setVotingInprogress(false)
Expand Down Expand Up @@ -262,7 +264,8 @@ export const AiFeedbackActions: FC<AiFeedbackActionsProps> = props => {
downVote: down,
upVote: up,
})
await mutate(`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun.id}/items`)
// eslint-disable-next-line max-len
await mutate(`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items?[${workflowRun?.status}]`)
} catch (err) {
setUserVote(prevUserVote)
setUpVotes(prevUp)
Expand Down
8 changes: 6 additions & 2 deletions ...ents/Scorecard/ScorecardViewer/ScorecardQuestion/AiFeedbackComments/AiFeedbackComment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,19 @@ export const AiFeedbackComment: FC<AiFeedbackCommentProps> = props => {
content,
parentId: comment.id,
})
await mutate(`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items`)
await mutate(`
${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items?[${workflowRun?.status}]
`)
setShowReply(false)
}, [workflowId, workflowRun?.id, props.feedback?.id])

const onEditReply = useCallback(async (content: string, comment: AiFeedbackCommentType) => {
await updateRunItemComment(workflowId as string, workflowRun?.id as string, props.feedback?.id, comment.id, {
content,
})
await mutate(`${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items`)
await mutate(`
${EnvironmentConfig.API.V6}/workflows/${workflowId}/runs/${workflowRun?.id}/items?[${workflowRun?.status}]
`)
setEditMode(false)
}, [workflowId, workflowRun?.id, props.feedback?.id])

Expand Down
Loading