PROD-2437 Patch Challenge -> PROD-2321 Bug Hunt Intake #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 8, 2022 16:43
… Modified price and timeline models. #time 6h
…D-2437_patch-challenge #time 5m
… and Pay button #time 4h
Author
|
Optional reviewers: @casey-tc @brooketopcoder |
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Outdated
Show resolved
Hide resolved
src-ts/tools/work/work-lib/work-provider/work-functions/work-store/work-prices.config.ts
Show resolved
Hide resolved
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Outdated
Show resolved
Hide resolved
dave-armstrong-topcoder
approved these changes
Jul 19, 2022
dave-armstrong-topcoder
left a comment
dave-armstrong-topcoder
left a comment
There was a problem hiding this comment.
A couple comments that are more tangents to this PR than anything that needs changed, and one minor question on using lodash. But overall, looks good!
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Outdated
Show resolved
Hide resolved
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Show resolved
Hide resolved
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Show resolved
Hide resolved
Collaborator
hentrymartin
left a comment
hentrymartin
left a comment
There was a problem hiding this comment.
Added some comments and questions, apart from that the PR looks really great!
src-ts/tools/work/work-lib/work-provider/work-functions/work-factory/work.factory.ts
Outdated
Show resolved
Hide resolved
added 5 commits
July 19, 2022 13:21
… to metadata before formatting #time 30m
hentrymartin
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Saves the intake data when user clicks on 'Complete and Pay' button
Note that no other action is currently performed upon button click other than saving the data.
Screenshots
We can see name is getting saved as it displays on the Drafts table:
Work intake appears in Work Manager:
