PROD-2740 Update loading spinner -> dev

[brooketopcoder]

https://topcoder.atlassian.net/browse/PROD-2740

The loading spinner was incorrectly implemented and needs to be refactored. Please verify the spinner correctly displays if the data doesn’t load right away in the following locations:

Learn

• viewing a certificate
• course completed
• course details
• lesson
• course outline panel
• welcome page

Work

• Work Details → detail
• Bug Hunt intake form
• Save after login (start an intake logged out then log in when you need to review and submit.)
• Dashboard

[testflyjets]

@brooketopcoder I've run through all the pages and the spinner seems to work, but I'm not sure how it wasn't working before, so it's not clear to me if what I'm seeing is correct. Can you clarify what I should or shouldn't see -- how was it broken before?

[vas3a]

I feel like the LoadingSpinner's show property should default to true. This way when we add <LoadingSpinner /> it's visible (if it's hidden without specifying a param, eg show={false}, it is confusing).

[brooketopcoder]

I feel like the LoadingSpinner's show property should default to true. This way when we add <LoadingSpinner /> it's visible (if it's hidden without specifying a param, eg show={false}, it is confusing).

I totally agree. Booleans should always default to false. I will make this fix...

[brooketopcoder]

@vas3a i made the changes you suggested and improved the loading UI in a couple places.

I also added some error handling bc we are getting a 500 from the dev api when trying to get course progress.

[vas3a]

awesome!