PROD-2749 - fix navigation on fcc #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PROD-2749
Lesson not progressing to next step
The deps array for an useEffect doesn't need to always be exhaustive. I should have added the ignore rule for this from the beginning.
Eg. routeParams triggers the effect, and when this is called, the rest of the values are taken from current context anyway, so we're fine, we're not using deprecated values. But it is imperative that only routeParams is the one to trigger the effect.
I'll merge the fix for now so it is deployed and the UI is not stuck, but we can discuss later anyway.