Skip to content

Fix for BH Log In form & Review page -> dev #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Fix for BH Log In form & Review page -> dev #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src-ts/tools/work/work-self-service/intake-forms/bug-hunt/BugHuntIntakeForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,10 @@ const BugHuntIntakeForm: React.FC = () => {
if (!workId && !challenge) {
formOnReset(formInputs, formValues)
}
}, [
challenge,
formInputs,
formValues,
workId,
])
// Disabling lint rule as we only want this to run one time when component mounts, otherwise it resets
// the form for a user that is not logged in and has no challenge created yet
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [])

useEffect(() => {

Expand Down
15 changes: 6 additions & 9 deletions src-ts/tools/work/work-self-service/intake-forms/review/Review.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,22 +102,19 @@ const Review: FC = () => {
})
}
getAndSetWork()
}, [
formFieldValues,
userProfile,
workId,
])
// Disabling to avoid infite re-renders
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [workId])

useEffect(() => {
setFormValues({
...formFieldValues,
email: profile?.email || '',
name: `${profile?.firstName} ${profile?.lastName}`,
})
}, [
formFieldValues,
profile,
])
// Disabling to avoid infite re-renders
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [profile])

const onUpdateField: (fieldName: string, value: string | boolean) => void = (fieldName, value) => {
setFormValues({
Expand Down