GAME-73 #280
Merged
GAME-73 #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooketopcoder
approved these changes
Aug 30, 2022
Contributor
brooketopcoder
left a comment
brooketopcoder
left a comment
There was a problem hiding this comment.
@kkartunov This PR is excellent! It's exactly what we discussed, and I find your code style/comments really easy to parse.
I didn't find any issues w/the architecture decisions, etc., so I am going to approve the PR.
I have a bunch of comments regarding my personal preferences, which are of course personal and by no means required, but I add them as a basis for discussion.
It would be great if you could address the comments you agree with before merging.
src-ts/lib/route-provider/require-auth-provider/require-auth.provider.tsx
Outdated
Show resolved
Hide resolved
src-ts/lib/route-provider/require-auth-provider/require-auth.provider.tsx
Outdated
Show resolved
Hide resolved
src-ts/lib/route-provider/require-auth-provider/require-auth.provider.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/GAME-73?atlOrigin=eyJpIjoiMjVjMzE0MjY0ZWI3NDcxZTkzODc0MGI4NGUxMzNlNDkiLCJwIjoiaiJ9