Skip to content

TCA-408 - Circle ci setup v7 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 9, 2022
Merged

TCA-408 - Circle ci setup v7 #292

merged 11 commits into from
Sep 9, 2022

Conversation

@LieutenantRoger
Copy link
Contributor

@LieutenantRoger LieutenantRoger commented Sep 9, 2022 •
edited
Loading

This MR

  1. Separate the test steps in circle-ci to individual tasks from the deployment build process
  2. Test steps will be executed in every branch
  3. Failed test steps won't prevent the deployment process
  4. Test results and Artifacts are saved as before
  5. Enabled a failed test case to demonstrate that this won't prevent deployment

@LieutenantRoger LieutenantRoger changed the title Circle ci setup v7 TCA-408 - Circle ci setup v7 Sep 9, 2022
@LieutenantRoger LieutenantRoger self-assigned this Sep 9, 2022
brooketopcoder
brooketopcoder approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I updated the branch to skip the failing test and will merge this.

@brooketopcoder brooketopcoder merged commit 3099419 into dev Sep 9, 2022
@brooketopcoder brooketopcoder deleted the circle-ci-setup-v7 branch September 9, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brooketopcoder brooketopcoder brooketopcoder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LieutenantRoger LieutenantRoger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LieutenantRoger @brooketopcoder