Skip to content

TCA-440: call certification completion based on assessment completion #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

TCA-440: call certification completion based on assessment completion #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5847cac
TCA-440: call certification completion based on assessment completion
vas3a Sep 15, 2022
0ea5539
lint fix
vas3a Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-ts/tools/learn/free-code-camp/FreeCodeCamp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ const FreeCodeCamp: FC<{}> = () => {
useEffect(() => {
if (
certificateProgress &&
certificateProgress.courseProgressPercentage === 100 &&
certificateProgress.certificationProgressPercentage === 100 &&
certificateProgress.status === UserCertificationProgressStatus.inProgress
) {
userCertificationProgressUpdateAsync(
Expand Down
1 change: 1 addition & 0 deletions src-ts/tools/learn/learn-lib/course-outline/CourseOutline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const CourseOutline: FC<CourseOutlineProps> = (props: CourseOutlineProps) => {
shortDescription={module.meta.introCopy}
title={module.meta.name}
onItemClick={props.onItemNavigate}
isAssessment={module.meta.isAssessment}
/>
))}
</div>
Expand Down
5 changes: 2 additions & 3 deletions src-ts/tools/learn/learn-lib/course-outline/collapsible-item/CollapsibleItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ interface CollapsibleListItem {
interface CollapsibleItemProps {
active?: string
duration: LearnModule['meta']['estimatedCompletionTime']
isAssessment: boolean
itemId?: (item: any) => string
items: Array<CollapsibleListItem>
lessonsCount: number
Expand All @@ -31,8 +32,6 @@ interface CollapsibleItemProps {
const CollapsibleItem: FC<CollapsibleItemProps> = (props: CollapsibleItemProps) => {
const [isOpen, setIsOpen]: [boolean, Dispatch<SetStateAction<boolean>>] = useState<boolean>(false)

const isAssessment: boolean = props.lessonsCount === 1

const toggle: () => void = useCallback(() => {
setIsOpen(open => !open)
}, [])
Expand Down Expand Up @@ -89,7 +88,7 @@ const CollapsibleItem: FC<CollapsibleItemProps> = (props: CollapsibleItemProps)
<div className={styles['title-row']} onClick={toggle}>
<StatusIcon completed={isCompleted} partial={isPartial} />
<span className={styles['title']}>
{isAssessment && (
{props.isAssessment && (
<div className={classNames(styles['title-tag'], 'label')}>
assessment
</div>
Expand Down
2 changes: 1 addition & 1 deletion src-ts/tools/learn/learn-lib/lesson-provider/learn-module-meta.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ export interface LearnModuleMeta {
value: number
}
introCopy: Array<string>
lessonCount: number
isAssessment: boolean
name: string
}
2 changes: 2 additions & 0 deletions ...cations-provider/user-certifications-functions/learn-user-certification-progress.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ export interface LearnUserCertificationProgress extends LearnModelBase {
academicHonestyPolicyAcceptedAt?: number,
certification: string
certificationId: string
certificationProgressPercentage: number
certType: 'certification'
completedDate?: string
courseId: string
courseKey: string
Expand Down