Skip to content

Conversation

@kkartunov
Copy link
Collaborator

@kkartunov kkartunov commented Sep 23, 2022

@kkartunov
Copy link
Collaborator Author

https://topcoder.atlassian.net/browse/GAME-82?atlOrigin=eyJpIjoiMjI4YzhjYzg3MzIyNDM2NjljNmZmNGIwODcxOTZiNDYiLCJwIjoiaiJ9

Platform UI updates:

@brooketopcoder brooketopcoder changed the base branch from gamification to dev September 23, 2022 16:32
@brooketopcoder brooketopcoder changed the base branch from dev to gamification September 23, 2022 16:32
Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive! I love how you simplified things like the InputValue. And the way you configured the UI is great.

The image picker will be used a lot.

I only have 1 super minor suggestion about some prop names, otherwise, it's ready to rock.

export type InputValue = string | boolean | FileList | undefined

export interface FormInputModel {
readonly accept?: string
Copy link
Contributor

@brooketopcoder brooketopcoder Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of a generic form input, accept and size don't really make sense bc there's no indication they relate to files. Can we either rename the properties or nest them? Something like...

export interface FormInputModel {
    ...
    readonly fileConfig?: {
        readonly acceptFileType?: string
        readonly maxFileSize?: number
    }
   ...
}

or

   readonly fileTypeAccepted?: string
   readonly fileSizeMax?: number

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Better config also included with aa0b97f
Merging this upstream for QA...

@kkartunov kkartunov merged commit 5c5f502 into gamification Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants