-
Notifications
You must be signed in to change notification settings - Fork 21
Feat/game 82 #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/game 82 #305
Conversation
…rt checkboxes #time 1h
GAME-108 Support Checkboxes -> fix/GAME-108
Fix/game 108
|
Platform UI updates:
|
brooketopcoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very impressive! I love how you simplified things like the InputValue. And the way you configured the UI is great.
The image picker will be used a lot.
I only have 1 super minor suggestion about some prop names, otherwise, it's ready to rock.
src-ts/lib/form/form-input.model.ts
Outdated
| export type InputValue = string | boolean | FileList | undefined | ||
|
|
||
| export interface FormInputModel { | ||
| readonly accept?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of a generic form input, accept and size don't really make sense bc there's no indication they relate to files. Can we either rename the properties or nest them? Something like...
export interface FormInputModel {
...
readonly fileConfig?: {
readonly acceptFileType?: string
readonly maxFileSize?: number
}
...
}
or
readonly fileTypeAccepted?: string
readonly fileSizeMax?: number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Better config also included with aa0b97f
Merging this upstream for QA...
#305 (comment)