Skip to content

TCA-438 Fix Missing Checkmark in Safari #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2022
Merged

TCA-438 Fix Missing Checkmark in Safari #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d8b4d0
TCA-438 #comment This commit does a first pass to get the check icon …
brooketopcoder Oct 4, 2022
149995f
TCA-438 - update status icon size for course outline
vas3a Oct 4, 2022
e9a80e3
update README - svg icons
vas3a Oct 4, 2022
f6536d4
add mixin for full size (100%) icon
vas3a Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,3 +509,5 @@ e.g.:
}
}
```

>**NOTE** - all SVGs require explicit `width` and `height` in the Safari browser in order to be rendered properly, otherwise they'll be rendered to the _default_ size and probably will crop out of view
5 changes: 5 additions & 0 deletions src-ts/lib/styles/mixins/_icons.mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
width: $space-mxx;
}

@mixin icon-full {
height: 100%;
width: 100%;
}

@mixin icon-size($size) {
height: $size * 1px;
width: $size * 1px;
Expand Down
5 changes: 4 additions & 1 deletion src-ts/tools/learn/learn-lib/course-outline/status-icon/StatusIcon.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@
.checkmark {
@include icon-size(26);
flex: 0 0 auto;
}
svg {
@include icon-full;
}
}
4 changes: 3 additions & 1 deletion src-ts/tools/learn/learn-lib/course-outline/step-icon/StepIcon.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
color: $black-20;

.icon {

@include icon-xl;
border-radius: 50%;
flex: 0 0 auto;
Expand All @@ -21,6 +22,7 @@
background: $black-40;

> svg {
@include icon-full;
margin: -1 * $border;
}
}
Expand All @@ -43,4 +45,4 @@
background: $tc-white;
}
}
}
}
2 changes: 1 addition & 1 deletion src-ts/tools/learn/learn-lib/course-outline/step-icon/StepIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const StepIcon: FC<StepIconProps> = (props: StepIconProps) => {
return (
<>
{props.label && props.completed && (
<IconSolid.CheckCircleIcon />
<IconSolid.CheckCircleIcon viewBox='2 2 16 16' />
)}

{!props.label && (
Expand Down