TCA-407 my learning filtering -> dev #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
reviewed
Oct 19, 2022
testflyjets
approved these changes
Oct 19, 2022
Contributor
brooketopcoder
left a comment
brooketopcoder
left a comment
There was a problem hiding this comment.
@vas3a This all looks good. I am wondering if there's any of the sorting or filtering code that can be made reusable in the main lib?
Collaborator
Author
|
@brooketopcoder I'll have another look at it and I'll update this PR if I can find something. |
Collaborator
Author
|
@brooketopcoder I can't find any common denominator for a general use. If we find something later I can refactor this and reuse as needed. |
brooketopcoder
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/TCA-407
Adds filter, sorting & tabs navbar for completed/in progress selection in My Learnings page.