TCA-550 - add a new style for the certificate view to allow screensho… #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for social platform
brooketopcoder
suggested changes
Oct 20, 2022
Contributor
brooketopcoder
left a comment
brooketopcoder
left a comment
There was a problem hiding this comment.
Looks good. just one request...
|
|
||
| &:global(.large-container) { | ||
| aspect-ratio: unset; | ||
| width: 1200px; |
Contributor
There was a problem hiding this comment.
can we make this a ratio a mixin in case we do share other images via social media?
Collaborator
Author
There was a problem hiding this comment.
@brooketopcoder I'm not sure what you mean by ratio a mixin. Do you mean the 1200/630px size?
Contributor
There was a problem hiding this comment.
@vas3a yeah. something like...
@mixin social-preview {
aspect-ratio: unset;
width: 1200px;
height: 630px;
}
testflyjets
approved these changes
Oct 20, 2022
brooketopcoder
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/TCA-550
Adds a new style for the certificate view that is more optimized for social platforms. To trigger this view you need to add a query parameter
?view-style=large-container. This will change the container for the certificate to 1200px/630px.