Skip to content

TCA-584 Generate Social Optimized Images -> TCA-516_optimize-certificate-for-social #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

TCA-584 Generate Social Optimized Images -> TCA-516_optimize-certificate-for-social #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src-ts/tools/learn/learn-config/learn-config.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export interface LearnConfigModel {
API: string
CERT_ALT_PARAMS: { [key: string]: string }
CERT_DOMAIN: string
CERT_ELEMENT_SELECTOR: {
attribute: string,
Expand Down
3 changes: 3 additions & 0 deletions src-ts/tools/learn/learn-config/learn.default.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { LearnConfigModel } from './learn-config.model'

export const LearnConfigDefault: LearnConfigModel = {
API: 'http://localhost:3001/v5/learning-paths',
CERT_ALT_PARAMS: {
'view-port': 'large-container',
},
CERT_DOMAIN: 'https://certificate.topcoder-dev.com',
CERT_ELEMENT_SELECTOR: {
attribute: 'data-id',
Expand Down
5 changes: 2 additions & 3 deletions ...ertifications-provider/user-certifications-functions/user-certification-progress.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { logInfo } from '../../../../../lib'
import { LearnConfig } from '../../../learn-config'
import { getUserCertificateUrl } from '../../../learn.routes'
import { learnUrlGet, learnXhrGetAsync, learnXhrPostAsync, learnXhrPutAsync } from '../../functions'
Expand All @@ -16,15 +15,15 @@ export function completeCourse(
): Promise<LearnUserCertificationProgress> {

// construct the certificate params
const certificateAlternateParams: { [key: string]: string } = LearnConfig.CERT_ALT_PARAMS
const certificateElement: string = `[${LearnConfig.CERT_ELEMENT_SELECTOR.attribute}=${LearnConfig.CERT_ELEMENT_SELECTOR.value}]`
const certificateUrl: string = getUserCertificateUrl(provider, certification, handle)

logInfo(`Completing course w certificate URL = ${certificateUrl}`)

return updateAsync(
certificationProgressId,
UserCertificationUpdateProgressActions.completeCertificate,
{
certificateAlternateParams,
certificateElement,
certificateUrl,
}
Expand Down