Skip to content

TCA-589 - move modal contents to separate files and fetch them later -> TCA-586 #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2022
Merged

TCA-589 - move modal contents to separate files and fetch them later -> TCA-586 #392

merged 2 commits into from
Oct 28, 2022

Conversation

@vas3a
Copy link
Collaborator

@vas3a vas3a commented Oct 27, 2022

https://topcoder.atlassian.net/browse/TCA-589

Moves modals contents into separate files and fetches them later (on modal open) rather than bundling them in the main JS file.

@vas3a vas3a self-assigned this Oct 27, 2022
brooketopcoder
brooketopcoder approved these changes Oct 27, 2022
View reviewed changes
@vas3a vas3a merged commit 23ef630 into TCA-586_page-load-improvements Oct 28, 2022
@vas3a vas3a deleted the TCA-589_move-modal-contents-to-asset-files branch October 28, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brooketopcoder brooketopcoder brooketopcoder approved these changes

@testflyjets testflyjets testflyjets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vas3a vas3a

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vas3a @testflyjets @brooketopcoder