TCA-645 Example Complex Lint Fixes -> TCA-499_eslint #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vas3a
reviewed
Nov 8, 2022
...ility-selectors/UtilitySelector/ProfileSelector/profile-not-logged-in/ProfileNotLoggedIn.tsx
Outdated
Show resolved
Hide resolved
vas3a
reviewed
Nov 8, 2022
src-ts/tools/gamification-admin/pages/badge-detail/BadgeDetailPage.tsx
Outdated
Show resolved
Hide resolved
vas3a
approved these changes
Nov 8, 2022
Collaborator
vas3a
left a comment
vas3a
left a comment
There was a problem hiding this comment.
Looks good to me, just that thought on resolving the react/jsx-no-bind rule.
…how it worked and made the issue worse. Thanks Vasilica #time 15m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives examples for how to fix several lint issues:
And a couple more obvious ones.