TCA-852 Check for Dice -> TCA-851_wipro-mfa #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from access any TCA lesson. #time 1h
testflyjets
approved these changes
Dec 23, 2022
Contributor
testflyjets
left a comment
testflyjets
left a comment
There was a problem hiding this comment.
Really clean implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the code necessary to prevent wipro users w/out dice enabled from accessing any TCA lesson.
The next PR will add the modal to explain why.
I also snuck in a bug fix for the footer not loading for me locally. It works correctly in dev, so I assume it's just a timing thing.