TCA-1018 better modal view #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kkartunov
commented
Feb 21, 2023
kkartunov
commented
- Better looking layout inside the modal on profile page.
- fixes https://topcoder.atlassian.net/browse/TCA-1021 too
vas3a
reviewed
Feb 21, 2023
| } | ||
| } | ||
|
|
||
| :global(p.body-large) { |
Collaborator
There was a problem hiding this comment.
can you use .body-medium from typography instead of overwriting the style in here?
.body-medium has support for mobile view as well 👍
vas3a
approved these changes
Feb 21, 2023
Collaborator
vas3a
left a comment
vas3a
left a comment
There was a problem hiding this comment.
looks good, just one minor change req.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.