Skip to content

Conversation

@kkartunov
Copy link
Collaborator

Implements free promo, banner, details and enrollment pages.

Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on how this is implemented we will have to do a similar code change to undo this. Did we give consideration to having a toggle, for example, via an env var, to turn the "FREE" on and off?

Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkartunov can you use either svg or css gradients for the yellow/orange backgrounds? 66KB is pretty high for this. (see issues raised by QA & glenn that the BG for the enrolled modal which was 50KB was loading slowly)

Otherwise, looks good to me

@kkartunov
Copy link
Collaborator Author

@kkartunov can you use either svg or css gradients for the yellow/orange backgrounds? 66KB is pretty high for this. (see issues raised by QA & glenn that the BG for the enrolled modal which was 50KB was loading slowly)

Otherwise, looks good to me

@testflyjets yeah, that is my general approach. In this cas tho' there are some figures in that gradient, less visible but they are there, which I am tying to have as per design.
image

@kkartunov kkartunov merged commit 8dab0d0 into dev Feb 24, 2023
@kkartunov kkartunov deleted the TCA-1077 branch February 27, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants