Skip to content

TCA-1279 - hide header & footer for hiring manager view in modal mode -> dev #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023
Merged

TCA-1279 - hide header & footer for hiring manager view in modal mode -> dev #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src-ts/tools/learn/learn-lib/hiring-manager-view/HiringManagerView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
ReactNode,
SetStateAction,
useCallback,
useLayoutEffect,
useMemo,
useRef,
useState,
Expand Down Expand Up @@ -36,7 +35,7 @@ import {
useTCAShareCertificateModal,
} from '..'
import { getTCACertificationPath, getUserTCACertificateSsr } from '../../learn.routes'
import { clearFCCCertificationTitle, hideSiblings } from '../functions'
import { clearFCCCertificationTitle } from '../functions'
import { EnvironmentConfig } from '../../../../config'

import { CertificateModal } from './certificate-modal'
Expand Down Expand Up @@ -68,7 +67,6 @@ export interface HiringManagerViewProps {
// eslint-disable-next-line complexity
const HiringManagerView: FC<HiringManagerViewProps> = (props: HiringManagerViewProps) => {
const certificateElRef: MutableRefObject<HTMLDivElement | any> = useRef()
const wrapElRef: MutableRefObject<HTMLElement | any> = useRef()

const [certPreviewModalIsOpen, setCertPreviewModalIsOpen]: [boolean, Dispatch<SetStateAction<boolean>>]
= useState<boolean>(false)
Expand Down Expand Up @@ -253,19 +251,8 @@ const HiringManagerView: FC<HiringManagerViewProps> = (props: HiringManagerViewP
)
}

useLayoutEffect(() => {
const el: HTMLElement = wrapElRef.current
if (!el || !props.isModalView) {
return
}

hideSiblings(el.parentElement as HTMLElement)
hideSiblings(el.parentElement?.parentElement as HTMLElement)

})

return !!props.certification && !!props.userProfile ? (
<div className={props.isModalView ? styles.modalView : ''} ref={wrapElRef}>
<div className={props.isModalView ? styles.modalView : ''}>
{renderHero()}

<ContentLayout
Expand Down
20 changes: 16 additions & 4 deletions src-ts/tools/learn/tca-certificate/user-certification-view/UserCertificationViewBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
MutableRefObject,
SetStateAction,
useEffect,
useLayoutEffect,
useRef,
useState,
} from 'react'
Expand All @@ -16,6 +17,7 @@ import {
} from '../../../../lib'
import {
CertificatePageLayout,
hideSiblings,
HiringManagerView,
PageTitle,
TCACertification,
Expand All @@ -34,6 +36,7 @@ interface UserCertificationViewBaseProps {

const UserCertificationViewBase: FC<UserCertificationViewBaseProps> = (props: UserCertificationViewBaseProps) => {
const [queryParams]: [URLSearchParams, any] = useSearchParams()
const wrapElRef: MutableRefObject<HTMLElement | any> = useRef()

const tcaCertificationPath: string = getTCACertificationPath(`${props.certification?.dashedName}`)
const certificateElRef: MutableRefObject<HTMLDivElement | any> = useRef()
Expand All @@ -55,6 +58,15 @@ const UserCertificationViewBase: FC<UserCertificationViewBaseProps> = (props: Us
.then(verified => setIsMemberVerified(verified))
}, [props.enrollment])

useLayoutEffect(() => {
const el: HTMLElement = wrapElRef.current
if (!el || !isModalView) {
return
}

hideSiblings(el.parentElement as HTMLElement)
}, [isModalView])

return (
<>
<PageTitle>
Expand All @@ -74,8 +86,8 @@ const UserCertificationViewBase: FC<UserCertificationViewBaseProps> = (props: Us
</CertificatePageLayout>
)}

{props.profile && props.certification && props.enrollment && (
<div className='full-height-frame'>
<div className='full-height-frame' ref={wrapElRef}>
{props.profile && props.certification && props.enrollment && (
<HiringManagerView
certification={props.certification}
completedAt={(props.enrollment.completedAt ?? undefined) as string}
Expand All @@ -88,8 +100,8 @@ const UserCertificationViewBase: FC<UserCertificationViewBaseProps> = (props: Us
isPreview={props.isPreview}
isModalView={isModalView}
/>
</div>
)}
)}
</div>
</>
)
}
Expand Down