TCA-1281 - update routing: support friendlier urls on subdomains -> dev #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
reviewed
May 5, 2023
src/constants/index.js
Outdated
| WEBSITE_DESIGN_LEGACY: "/self-service/work/new/website-design-legacy/basic-info", | ||
| INTAKE_FORM: `${selfServiceRootRoute}/wizard`, | ||
| HOME_PAGE: `${selfServiceRootRoute}`, | ||
| DASHBOARD_PAGE: `/work/dashboard`, |
Contributor
There was a problem hiding this comment.
With the work subdomain, should this be just /dashboard ?
Collaborator
Author
There was a problem hiding this comment.
Correct, thanks for catching that! I used rootRoute as a base, to keep support for local development (so when you're note on work.topcoder-dev.com, you can go to local.topcoder-dev.com/work/dashboard).
testflyjets
approved these changes
May 5, 2023
Contributor
testflyjets
left a comment
testflyjets
left a comment
There was a problem hiding this comment.
Really great work. I'm sure this was tedious but it makes the code cleaner and sets up some actually human-rememberable routes!
maxtopc
approved these changes
May 5, 2023
kkartunov
approved these changes
May 8, 2023
Collaborator
Author
Exactly! it doesn't matter the tedious work as long as the end result is worth it 👍 |
testflyjets
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets:
https://topcoder.atlassian.net/browse/TCA-1281
https://topcoder.atlassian.net/browse/TCA-1226
Updates the Router implementation to support apps hosted from subdomains. To be more precise, the current apps can be served from:
platform-ui.topcoder.com/learn → academy.topcoder.com
platform-ui.topcoder.com/dev-center → devcenter.topcoder.com
platform-ui.topcoder.com/gamification-admin → gamification-admin.topcoder.com
platform-ui.topcoder.com/work → work.topcoder.com
For local development support and ease, if the subdomain doesn't match any known app subdomain, it will use the subdomain as a starting prefix for the path. Eg:
local.topcoder-dev.com/academylocal.topcoder-dev.com/devcenterlocal.topcoder-dev.com/gamification-adminlocal.topcoder-dev.com/workNote: to accommodate the part where we removed the base path for all routes, for the self service, I ditched the "/work" part from the urls. The urls were a bit messed, but I think this should make them more straight forward. eg: