Skip to content

Issue #673 #675 #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Issue #673 #675 #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/apps/onboarding/src/components/connect-linked-in/index.tsx
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion src/apps/onboarding/src/pages/educations/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ export const PageEducationsContent: FC<{
useEffect(() => {
if (!educations && props.reduxEducations) {
setEducations(props.reduxEducations)
setEducationId(props.reduxEducations[props.reduxEducations.length - 1].id + 1)
if (props.reduxEducations.length > 0) {
setEducationId(props.reduxEducations[props.reduxEducations.length - 1].id + 1)
}
}
/* eslint-disable react-hooks/exhaustive-deps */
}, [props.reduxEducations])
Expand Down
3 changes: 0 additions & 3 deletions src/apps/onboarding/src/pages/skills/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import SkillInfo from '../../models/SkillInfo'
import SkillTag from '../../components/skill-tag'

import styles from './styles.module.scss'
import ConnectLinkedIn from '../../components/connect-linked-in'

const PageSkillsContent: FC<{
memberInfo?: Member,
Expand Down Expand Up @@ -109,8 +108,6 @@ const PageSkillsContent: FC<{
/>
</div>
</div>

<ConnectLinkedIn />
</div>

<ProgressBar
Expand Down
10 changes: 2 additions & 8 deletions src/apps/onboarding/src/pages/start/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,8 @@ export const PageStart: FC<{}> = () => {

<div className={classNames('d-flex justify-content-between flex-wrap mt-30', styles.blockOr)}>
<div>
<span>We can extract data from your LinkedIn profile or a digital version of your resume.</span>
<span>We can extract data from a digital version of your resume.</span>
<div className={classNames(styles.blockImportButtons, 'd-flex')}>
<Button
size='lg'
secondary
iconToLeft
>
import from linked in
</Button>
<Button
size='lg'
secondary
Expand Down Expand Up @@ -71,6 +64,7 @@ export const PageStart: FC<{}> = () => {
size='lg'
primary
iconToLeft
onClick={() => navigate('../skills')}
>
next
</Button>
Expand Down
6 changes: 3 additions & 3 deletions src/apps/onboarding/src/pages/works/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { Button, PageDivider } from '~/libs/ui'

import { ProgressBar } from '../../components/progress-bar'
import styles from './styles.module.scss'
import ConnectLinkedIn from '../../components/connect-linked-in'
import WorkInfo from '../../models/WorkInfo'
import ModalAddWork from '../../components/modal-add-work'
import IconEdit from '../../assets/images/edit.svg'
Expand All @@ -33,7 +32,9 @@ export const PageWorksContent: FC<{
useEffect(() => {
if (!works && props.reduxWorks) {
setWorks(props.reduxWorks)
setWorkId(props.reduxWorks[props.reduxWorks.length - 1].id + 1)
if (props.reduxWorks.length > 0) {
setWorkId(props.reduxWorks[props.reduxWorks.length - 1].id + 1)
}
}
/* eslint-disable react-hooks/exhaustive-deps */
}, [props.reduxWorks])
Expand Down Expand Up @@ -99,7 +100,6 @@ export const PageWorksContent: FC<{
</span>
) : null}
</div>
<ConnectLinkedIn />
</div>

<ProgressBar
Expand Down