MP-190 notify uniNavi on member profile update -> dev #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@vas3a requesting your look on how the method to update is called... |
vas3a
approved these changes
Jul 10, 2023
src/apps/profiles/src/lib/helpers.ts
Outdated
| export function notifyUniNavi(profile: UserProfile): void { | ||
| if (window?.tcUniNav) { | ||
| window.tcUniNav('update', '*', { | ||
| user: profile, |
Collaborator
There was a problem hiding this comment.
Looks good! Only one issue: for some reason the API returns profile.photoURL but the uninav is accepting photoUrl. Can you do it like this?
window.tcUniNav('update', '*', {
user: { ...profile, photoUrl: profile.photoURL }
})
Collaborator
Author
There was a problem hiding this comment.
Ah, okay. This explains why navi photo looks weird after it executes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/
What's in this PR?